Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed documentation #396

Merged
merged 1 commit into from
Apr 30, 2024
Merged

fixed documentation #396

merged 1 commit into from
Apr 30, 2024

Conversation

pawelsz-rb
Copy link
Collaborator

@pawelsz-rb pawelsz-rb commented Apr 30, 2024 •
edited
Loading

Description of the change

This fixes a problem in the documentation around importing existing Rollbar users into rollbar_user resources - import is not via user ID - but must be via email address.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

#395

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@pawelsz-rb pawelsz-rb requested a review from waltjones April 30, 2024 06:15
@codeclimate CodeClimate
Copy link

codeclimate bot commented Apr 30, 2024

Code Climate has analyzed commit a098a5e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 92.0% (0.0% change).

View more on Code Climate.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8890147953

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.097%
Totals Coverage Status
Change from base Build 8449956416: 0.0%
Covered Lines: 1480
Relevant Lines: 1607
💛 - Coveralls

@pawelsz-rb pawelsz-rb mentioned this pull request Apr 30, 2024
Closed
12 tasks
@pawelsz-rb pawelsz-rb merged commit 5b51e25 into master Apr 30, 2024
19 checks passed
@pawelsz-rb pawelsz-rb deleted the pawel/fix_documentation branch April 30, 2024 14:38
@magnetikonline magnetikonline mentioned this pull request May 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waltjones waltjones waltjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pawelsz-rb @coveralls @waltjones